> nits: > 93 namespace { // Private for now. TODO: Finalize and publish later (LP: > #1422522) > comment needs removal
Done
> > 46 + > 47 + > extra whitespace
> 57 +MirSurfaceSpec::MirSurfaceSpec() > could we just remove this, and keep MirSurfaceSpec() = default?
We could, but there's no advantage to having it inline (and it might change as result of discussion).
« Back to merge proposal
> nits:
> 93 namespace { // Private for now. TODO: Finalize and publish later (LP:
> #1422522)
> comment needs removal
Done
>
> 46 +
> 47 +
> extra whitespace
Done
> 57 +MirSurfaceSpec ::MirSurfaceSpe c()
> could we just remove this, and keep MirSurfaceSpec() = default?
We could, but there's no advantage to having it inline (and it might change as result of discussion).