Mir

Code review comment for lp:~alan-griffiths/mir/first-pass-of-surface-spec-modification

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> nits:
> 93 namespace { // Private for now. TODO: Finalize and publish later (LP:
> #1422522)
> comment needs removal

Done

>
> 46 +
> 47 +
> extra whitespace

Done

> 57 +MirSurfaceSpec::MirSurfaceSpec()
> could we just remove this, and keep MirSurfaceSpec() = default?

We could, but there's no advantage to having it inline (and it might change as result of discussion).

« Back to merge proposal