Mir

Code review comment for lp:~alan-griffiths/mir/fatal-error

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

(1) OK, yeah I don't approve of this new form so don't want to be listed as sole author. Although it's slightly inconsiderate considering the amount of code copied from my branch to list yourself first.

(2) Alright, you like exceptions and I like guaranteed post-mortem analysis. Let us agree to disagree.

So now I have an additional question: What does this branch solve or fix? Certainly not the bug I set out to fix in: https://code.launchpad.net/~vanvugt/mir/fatal-error/+merge/219471
Unless you explicitly turn "abort" on in downstream projects...

If abort isn't turned on by default then following simple logic, either:
  (a) USC will want to turn it on always. So there's no reason to not make it the default in Mir for safety's sake, and go with my original proposal; or
  (b) USC will not want to turn it on. This leads to no bugs being fixed. No improvement on the current situation. So why does this proposal exist at all?

I'm not trying to be negative. The reasoning doesn't seem add up. Is it (a) or (b), or am I foolish and you all know about an option (c) I'm not seeing?

review: Disapprove

« Back to merge proposal