Mir

Code review comment for lp:~alan-griffiths/mir/extend-demo-client-display-config

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> Ah, I didn't make the non-nit part of that review clear:
>
> Non-nit:
> mir_demo_client_display_config crashes if you press ‘p’ before making any
> display configuration changes, due to print_current_configuration() not having
> a null-check on conf and nothing else assigns to conf in the startup process.

No, that was clear. I failed to push the correction.

« Back to merge proposal