Code review comment for lp:~alan-griffiths/mir/drag-and-drop-II

On 20/03/17 18:52, Brandon Schaefer wrote:
>> +void MirPointerEvent::set_dnd_handle(std::vector<uint8_t> const& handle)
>> +{
>> + event.getInput().getPointer().initDndHandle(handle.size());
>> + event.getInput().getPointer().setDndHandle(::kj::ArrayPtr<uint8_t const>{&*begin(handle), &*end(handle)});
> This could be done a bit different, though up to you:
> ::capnp::Data::Reader handle_data(handle.data(), handle.size());
> event.getInput().getPointer().setDndHandle(handle_data);
>

Tried this: The tests hang (didn't investigate further).

--
Alan Griffiths +44 (0)798 9938 758
Octopull Ltd http://www.octopull.co.uk/