Mir

Code review comment for lp:~alan-griffiths/mir/draft-surfaces-report

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

OK for the purpose of debugging this particular problem, but also +1 for SurfacesReport gradually evolving to a configurable, publicly accessible report, like the other reports we have in the code.

I find SurfacesReport::create_surface_call() being called after SurfacesReport::surface_created() a bit unintuitive without knowledge of the internals (I would expect the opposite order). Perhaps we could find a more descriptive name for the *_call() methods, but not a blocker at this point.

review: Approve

« Back to merge proposal