Mir

Code review comment for lp:~alan-griffiths/mir/default-to-canonical-window-manager

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> Just for clarity's sake, it took me a bit of staring to realize that there
> were 2 "CanonicalWindowManager" objects... and it might have been clearer if
> we had "StandardWindowManager" in src, and CanonicalWindowManager in examples
> maybe

There are several considerations to balance here and I'm not sure of the best resolution.

I'm not particularly fond of having duplicate code between shell and examples but that's what we decided on (for now).

As duplicate code is unusual I think there ought to be some strong suggestion of the existence of this duplication and corresponding names is one approach. How about this?

namespace shell { CanonicalWindowManager, BasicWindowManager, CanonicalWindowManagerPolicy, CanonicalSessionInfo, CanonicalSurfaceInfo }

namespace examples { CanonicalWindowManagerCopy, BasicWindowManagerCopy, CanonicalWindowManagerPolicyCopy, CanonicalSessionInfoCopy, CanonicalSurfaceInfoCopy }

« Back to merge proposal