Mir

Code review comment for lp:~alan-griffiths/mir/command-line-handling

Revision history for this message
Robert Carr (robertcarr) wrote :

Looks ok to me. I am not sure that std::function callback is the best API. Certainly

bla_init(int *argc, char ***argv)

is most popular in our ecosystem. So people will use like:

gst_init(argc, argv)
gtk_init(argc, argv)
myapp_init(argc, argv)

I guess server configuration construction is a little different though and I am open to a new pattern.

review: Approve

« Back to merge proposal