Mir

Code review comment for lp:~alan-griffiths/mir/add-glog-logging

Revision history for this message
Kevin DuBois (kdub) wrote :

i have to bump the android scripts and figure out why its not finding the glog library, i'll propose a branch to mp into this one about that. I'll block on myself with a 'needs fixing'

line 256/257, presumably we overload info because glog only has 4 levels?

line 98, is a bit chatty, for me, i see
...
-- Found GLog: /home/kdub/source/ndk-rewrite-glog/usr/lib/arm-linux-gnueabihf/libglog.so
-- Found LIBHARDWARE: /home/kdub/source/ndk-rewrite-glog/usr/lib/arm-linux-gnueabihf/libhardware.so.1
-- GLog_LIBRARY=/home/kdub/source/ndk-rewrite-glog/usr/lib/arm-linux-gnueabihf/libglog.so
...

review: Needs Fixing

« Back to merge proposal