Mir

Code review comment for lp:~alan-griffiths/mir/a-simpler-server-setup

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

> It isn't obvious, but either Self needs to be a public type or there needs to be a
> way of giving ServerConfiguration access to it.

Ah, indeed.

> This would make the declarations more concise.
> But it makes it harder for the user see the type they need to supply as a parameter.

Perhaps the first couple times the user will have to look up the type definition (which isn't hard since it will be in the same code block). But subsequently the user will read, e.g., "WrapperFunction<Type>" and just know what's expected, instead of having to mentally reparse the long parameter type every time.

« Back to merge proposal