Mir

Code review comment for lp:~alan-griffiths/mir/SwitchingBundle-controls-completion-of-client_acquire-without-blocking

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> It seems my original concerns [1] about thread safety are somewhat justified
> now, according to helgrind:
>
> development-branch: 236 errors from 8 contexts
> This branch: 1998 errors from 9 contexts
>
> Tested with:
> valgrind --tool=helgrind bin/mir_unit_tests
> --gtest_filter="SwitchingBundle*"
>
> [1] https://code.launchpad.net/~alan-griffiths/mir/refactoring-so-
> SwitchingBundle-can-control-completion-of-client_acquire/+merge/204244
>
> I can't immediately see what the new context is, but the significant increase
> in errors warrants some attention.

Giving it some attention.

« Back to merge proposal