Mir

Code review comment for lp:~alan-griffiths/mir/SwitchingBundle-controls-completion-of-client_acquire-without-blocking

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I notice you only eliminated one out of three wait() calls in client_acquire(). I think that's the significant one anyway.

Also, the removal of cond.notify_all() is potentially very dangerous with cond.wait()'s scattered throughout the code still. I can't yet tell if it's safe.

« Back to merge proposal