Code review comment for lp:~alan-griffiths/compiz-core/rework-updatePlugins

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Manual testing in precise is all good. The bugs are fixed.

But...
1. Please don't change formatting unnecessarily from func (x) to func(x). I agree with the latter but it's not what compiz uses.
2. You alternative between both styles inconsistently: func (x) and func(x)
3. The critical bugs this branch fixes are not mentioned anywhere and we don't have a usable commit message. But I can add those.

review: Approve

« Back to merge proposal