Code review comment for lp:~alan-griffiths/compiz-core/init-sequence-fix
Revision history for this message
| Alan Griffiths (alan-griffiths) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
> > 2. I don't like having the global "screen" variable at all - objects that
> need
> > a pointer to the CompScreen object should have it supplied on construction.
>
> This is probably a lot more feasible than it looks - all plugins are already
> passed a CompScreen on construction (DI), it is trivial for them to use that.
> As for the other objects - all windows can store a pointer to the CompScreen
> object and then the other stuff is also easy, although we really, for things
> like actions we should just be passing them interfaces for ActionStorage or
> whatever and the implementation is CompScreen (for now).
Yeah, I'll get to that in a later fix.