Code review comment for lp:~al-maisan/launchpad/pending-jobs-499861

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

This is that rubber stamp that jml mentioned.

We went through a few more small things in IRC: getPendingJobsQuery is now composePendingJobsQuery. Some docstrings and comments were polished up a bit more. And we now have a test verifying that BuildPackageJob really provides IBuildFarmJobDispatchEstimation.

Looks fine. Land that baby!

review: Approve (code)

« Back to merge proposal