Code review comment for lp:~al-maisan/launchpad/duration-485524

Hello Muharem,

I've tried to find you at UDS, but in any case it might be good to talk about this so that folks at home can play along too.

On IRC earlier, we talked a little about possibly moving this column to the Job table -- something that I thought was a sensible sounding idea but wanted a use case. Here, you move the estimated_duration column to the BuildQueue instead.

This, as I understand it, makes the estimated duration a property of a build a property of how it is scheduled, rather than an intrinsic part of the definition of the task. However, I feel my understanding is uncertain.

In your original comment, you say that this patch is supposed to make it possible to get job dispatch times irrespective of job type. However, given that you've almost certainly thought about this more than I have, I'd really appreciate it if you could add some information about how this achieves that goal, why it's the best solution, what trade-offs this makes (if any), and maybe give me a hint as to why the column placed onto the Build table in the first place.

Thanks,
jml