Code review comment for lp:~al-maisan/landscape-client/obsolete-results-v

Revision history for this message
Thomas Herve (therve) wrote :

It looks good!

[1] As it, the message context store will grow for ever. I think you should remove messages from it as soon as you add it to the message store (or discard it).

[2]
+ def _message_is_obsolete(self, message):
+ """True if message is obsolete.

Format "Returns C{True} if message is obsolete."

[3]
+class MessageContext(object):
+ """Stores the secure ID for incoming messages that require a response.

It seems to store more than that now.

[4]
+ """Accessing a C{MessageContext} with an existing
+ C{operation-id} works."""

+ """Calling C{all_operation_ids} on an empty database returns an empty
+ list."""

Please put the docstring on their own lines.

Thanks!

review: Needs Fixing

« Back to merge proposal