Merge lp:~akshaytayal/loco-team-portal/fixes-616383 into lp:loco-team-portal

[Akshay]

Added the ability to directly link to a comment.

[Ronnie (ronnie.vd.c)]

I played a bit with the css, and i think that the next css wil give a better result:

tr.comment.active {
    border-bottom: 2px dotted #DD4814;
    border-top: 2px dotted #DD4814;
}

[Ronnie (ronnie.vd.c)]

When there is a short comment, the table width is not 100%, which looks not very good. To prevent this. add the following code:

HTML, the name, comment-txt and link shoud have the following classes:
class="comment-name"
class="comment-comment"
class="comment-link"

Add this to your css (and remove the old .active - at the bottom):

#team-event-comments {
    width: 100%;
}

.comment {
    font-size: 0.8em;
}

.comment.active {
    background-color: #f7f7f7;
    border-bottom: 1px dotted #DD4814;
    border-top: 1px dotted #DD4814;
    margin: 0;
}

.comment-name {
    width: 0;
    padding-right: 8px;
}

.comment-link {
    padding-left: 8px;
    width: 0px;
}

With these changes, it looks a bit more consistent

[Akshay (akshaytayal)]

hi Ronnie,

Thanks for considering it again and sorry for late reply... :p.. I will make
these changes and commit it asap.

Akshay

On Mon, Apr 4, 2011 at 5:32 PM, Ronnie <email address hidden> wrote:

> When there is a short comment, the table width is not 100%, which looks not
> very good. To prevent this. add the following code:
>
> HTML, the name, comment-txt and link shoud have the following classes:
> class="comment-name"
> class="comment-comment"
> class="comment-link"
>
>
> Add this to your css (and remove the old .active - at the bottom):
>
> #team-event-comments {
> width: 100%;
> }
>
> .comment {
> font-size: 0.8em;
> }
>
> .comment.active {
> background-color: #f7f7f7;
> border-bottom: 1px dotted #DD4814;
> border-top: 1px dotted #DD4814;
> margin: 0;
> }
>
> .comment-name {
> width: 0;
> padding-right: 8px;
> }
>
> .comment-link {
> padding-left: 8px;
> width: 0px;
> }
>
>
> With these changes, it looks a bit more consistent
> --
>
> https://code.launchpad.net/~akshaytayal/loco-directory/fixes-616383/+merge/54246
> You are the owner of lp:~akshaytayal/loco-directory/fixes-616383.
>

[Adnane Belmadiaf (daker)]

It looks good to me, can we merge it ?

[Chris Johnston (cjohnston)]

I think that this section could be made to look better.. Currently the way that you have it, there is some text that is too small.. I'm thinking that it should look a little more like how Launchpad comments look. I've made a quick little drawing http://dl.dropbox.com/u/2494160/2011-06-10_14-55-14_739.jpg - The top are where the user name is should match the design guidelines and have a grey background similar to the background of the thead in the CSS. The text in this top area should probably also be bold, and white. Please let me know if you need any more assistance with this. Sorry that it has taken so long to get back to you.

[Chris Johnston (cjohnston)]

review: Needs Fixing

[Adnane Belmadiaf (daker)]

I have made a new one base on your code, thanks for your work.

[Akshay (akshaytayal)]

I learned a lot while working on this.

Than you!!
Akshay

On Sun, Sep 16, 2012 at 4:01 AM, Adnane Belmadiaf <email address hidden>wrote:

> I have made a new one base on your code, thanks for your work.
> --
>
> https://code.launchpad.net/~akshaytayal/loco-team-portal/fixes-616383/+merge/54246
> You are the owner of lp:~akshaytayal/loco-team-portal/fixes-616383.
>

[Adnane Belmadiaf (daker)]

Thanks for your work, this has been implemented now.

Unmerged revisions

423. By Akshay on 2011-04-09

Modified the code of table width for the short comments.

422. By Akshay on 2011-03-22

Changed the style for the border of the selected comment

421. By Akshay on 2011-03-21

Added the ability to directly link to a comment

=== modified file 'loco_directory/media/css/newstyle.css'
--- loco_directory/media/css/newstyle.css	2011-03-15 13:08:01 +0000
+++ loco_directory/media/css/newstyle.css	2011-04-09 11:05:51 +0000
@@ -479,3 +479,29 @@
     position: absolute; 
     right: 10px;
 }
+
+#team-event-comments {
+    width: 100%;
+}
+
+.comment {
+    font-size: 1.0em;
+}
+
+.comment.active {
+    background-color: #f7f7f7;
+    border-bottom: 1px dotted #DD4814;
+    border-top: 1px dotted #DD4814;
+    margin: 0;
+}
+
+.comment-name {
+    width: 0;
+    padding-right: 8px;
+}
+
+.comment-link {
+    padding-left: 8px;
+    width: 0px;
+}
+

=== modified file 'loco_directory/templates/events/team_event_detail.html'
--- loco_directory/templates/events/team_event_detail.html	2011-03-16 17:20:55 +0000
+++ loco_directory/templates/events/team_event_detail.html	2011-04-09 11:05:51 +0000
@@ -3,6 +3,22 @@
 
 {% block title %}{% trans team_event_object.name %} | {% trans "Ubuntu LoCo Team Directory" %} {% endblock %}
 
+{% block extrahead %}{{ block.super }}
+    <script type="text/javascript">
+    //<![CDATA[
+        $(function () {
+            $(location.hash).addClass('active');
+            $('.comment-link').click(function () {
+                setTimeout(function () {
+                    $('tr.comment').removeClass('active');
+                    $(location.hash).addClass('active');
+                }, 100);
+            });
+        });
+    //]]>
+    </script>
+{% endblock %}
+
 {% block sub_nav_links %}
 <a class="sub-nav-item" href="{% url event-list %}">{% trans "Back to Events List" %}</a>
 <a class="sub-nav-item" href="{% url team-event-comment-new team_event_object.first_team.lp_name team_event_object.id %}#comment">{% trans "Add Comment" %}</a>

=== modified file 'loco_directory/templates/events/team_event_detail_comments.inc.html'
--- loco_directory/templates/events/team_event_detail_comments.inc.html	2011-03-16 17:20:55 +0000
+++ loco_directory/templates/events/team_event_detail_comments.inc.html	2011-04-09 11:05:51 +0000
@@ -13,11 +13,24 @@
         <th class="form-item-label" scope="row" colspan=2><label>{{comment_date.grouper}}</label></th>
     </tr>
     {% for comment in comment_date.list %}
-    <tr>
-        <th class="form-item-label" scope="row"><label><a href="https://launchpad.net/~{{comment.commenter_profile.user.username}}">{{comment.commenter_profile.realname}}</a>:</label></th>
-        <td class="form-item-value">{{comment.comment}}</td>
+    <tr name="{{ forloop.counter }}" id="{{ forloop.counter }}" class="comment">
+        <th class="form-item-label class-name" scope="row"><label><a href="https://launchpad.net/~{{comment.commenter_profile.user.username}}">{{comment.commenter_profile.realname}}</a>:</label></th>
+        <td class="form-item-value comment-comment">{{comment.comment}}</td>
+        <td class="form-item-value comment-link"><a href="#{{ forloop.counter }}">#{{ forloop.counter }}</a></td>
     </tr>
     {% endfor %}
 {% endfor %}
 </table>
 {% endif %}
+
+
+
+
+
+
+
+
+
+
+
+