Code review comment for lp:~akretion-team/purchase-wkfl/70-add-purchase_fiscal_position_update

Revision history for this message
Alexis de Lattre (alexis-via) wrote :

@Stéphane

Thanks for pointing me to this interesting bug report.

I think that this module must be in sync with the state of the on_change of product_id in the purchase module in OCB-addons. For the moment, the on_change of product_id in OCB-addons doesn't take into account the default taxes if there are not taxes on the product. As soon as it changes, I will adapt my code to the new behavior. But I think it would be a mistake to change the code BEFORE the on_change of product_id is modified in the purchase module, because it would confuse users to have a different behavior when they add a new line in a PO vs when they update the fiscal position of the PO.

« Back to merge proposal