Code review comment for lp:~akretion-team/project-service/add-project-action-item

Revision history for this message
Lorenzo Battistini (elbati) wrote :

Thanks Alexis,
some style notes

project_action_item/__openerp__.py:52:9: E123 closing bracket does not match indentation of opening bracket's line
project_action_item/project.py:65:17: E123 closing bracket does not match indentation of opening bracket's line
project_action_item/project.py:66:13: E123 closing bracket does not match indentation of opening bracket's line
project_action_item/project.py:71:13: E123 closing bracket does not match indentation of opening bracket's line
project_action_item/project.py:76:9: E123 closing bracket does not match indentation of opening bracket's line
project_action_item/project.py:93:9: E123 closing bracket does not match indentation of opening bracket's line
project_action_item/project.py:100:13: E123 closing bracket does not match indentation of opening bracket's line
project_action_item/project.py:106:13: E123 closing bracket does not match indentation of opening bracket's line
project_action_item/project.py:113:13: E123 closing bracket does not match indentation of opening bracket's line
project_action_item/project.py:141:9: E123 closing bracket does not match indentation of opening bracket's line
project_action_item/project.py:176:17: E123 closing bracket does not match indentation of opening bracket's line
project_action_item/project.py:179:9: E123 closing bracket does not match indentation of opening bracket's line
project_action_item/wizard/update_action_generate_timesheet.py:39:9: E123 closing bracket does not match indentation of opening bracket's line
project_action_item/wizard/update_action_generate_timesheet.py:66:13: E123 closing bracket does not match indentation of opening bracket's line
project_action_item/wizard/update_action_generate_timesheet.py:89:13: E123 closing bracket does not match indentation of opening bracket's line
project_action_item/wizard/update_action_generate_timesheet.py:98:17: E123 closing bracket does not match indentation of opening bracket's line
project_action_item/wizard/update_action_generate_timesheet.py:136:17: E123 closing bracket does not match indentation of opening bracket's line

project_action_item/__openerp__.py:34:80: E501 line too long (250 > 79 characters)
project_action_item/__openerp__.py:36:80: E501 line too long (115 > 79 characters)
project_action_item/__openerp__.py:38:80: E501 line too long (120 > 79 characters)
project_action_item/__openerp__.py:51:80: E501 line too long (82 > 79 characters)

review: Needs Fixing

« Back to merge proposal