Code review comment for lp:~akretion-team/project-service/add-project-action-item

@Daniel Reis

I have implemented all your remarks :

* I would be nice to inform where the lp branch "hr_timesheet_task" can be found, at least until openerpapps.info rules the world.

=> Done

* The "Done with timesheet" is not a real button. It took me some time to realize it's test was clickable.

=> What do you suggest for that ?

* IMO "Done with timesheet" is a confusing label. I would prefer "Log on Timesheet" or the even simpler "Done".

=> We now have 2 buttons : "Done" and "Progress"

* Actions should heave a sequence field, and be manually reordered in the Task Actions tab.

=> They have that since my first commit :) Re-ordering action items works fine.

* If you have the "Manage time estimation on tasks" feature activated, the Task's estimated time should be computed as the total Actions estimated time (in the demo data, the Tasks estimated time is 22h and the Action estimated time is 70h).

=> Done?

* When an Action is Done, you can't see the actual time spent.

=> I added a field "timesheet_hours" on action items

* At the time you are creating the Action list, you should be able to set if you expect it to be billable (or expected Invoicing Ratio).

=> Done.

* You can't log time on an Action without completing it. The demo action "Develop final version" is 42h long, will surely span more than a week, and you will surely won't be able to wait until it's completed to log the time spent.
I suggest the wizard to let you log time on timesheet for an action, but keep it as not done / in progress.

=> Very good idea. Action items now have 3 states instead of 2 : todo, in progress and done.