Code review comment for lp:~akretion-team/openupgrade-addons/61-to-70-document

Revision history for this message
Sylvain LE GAL (GRAP) (sylvain-legal) wrote :

Just one thing. If you do not manage the case of the xml_id "dir_partner_category", the document.directory will be deleted ?
Why do you guess that this object is unused ?

What about to do in a pre-migration script a request like the following, to make the object persistent ?

delete * from ir_model_data where module ='document' and name ='dir_partner_category';

Otherwise, all looks good to me.

review: Needs Information (code review, no test.)

« Back to merge proposal