Odoo Addons (MOVED TO GITHUB)

Code review comment for lp:~akretion-team/openobject-addons/trunk-payment-term-on-purchase

  1. trunk-payment-term-on-purchase
  2. Merge into trunk
Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :

Hello Alexis,

this feature is long awaited and Renato and me confirm such a merge would save us from always doing this customization.

Now, I think you did little mistakes in manipulating Python boolean expressions, look lines 30 and 31 of the diff, you have code like:
'fiscal_position': supplier.property_account_position.id or False
it should instead be supplier.property_account_position and supplier.property_account_position.id or False.id or False
I believe there is the same error line 51 also.

Please fix that then it would be OK for me. Thanks for all that work, this is very good for the OpenERP product.

« Back to merge proposal