Code review comment for lp:~akretion-team/openobject-addons/trunk-fr-display-rib-and-iban

Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

Overall it looks fine.

Just a few things to fix before merging:
 - line 37 of diff below: please resolve the conflict (merge the trunk into your branch)
 - line 73: use '!=' instead of '<>' (the latter is obsolescent)
 - line 139: please use a better error message than 'Error message in raise'

Thanks,
Raphael

review: Needs Fixing

« Back to merge proposal