Code review comment for lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi,

Thanks for improving the module. I may not have the time to read all carefully, just what I saw in a few minutes here:

 * L269 : For the method "_get_default_warehouse", I prefer to get the WH through the user because take one from get_object_reference with stock0 will never work in a multi company. Taking the first WH of the user's company seems better to me.

 * L910-1010 : Removing all link and button to access the related partner's document is a bit sad don't you think ? Our customer love that. But you may have move that somewhere else and I missed it ?

Regards,

Joël

review: Needs Fixing (code review, no tests)

« Back to merge proposal