Merge lp:~akretion-team/openerp-product-attributes/openerp-product-attributes-product-image into lp:~product-core-editors/openerp-product-attributes/7.0
Status: | Needs review |
---|---|
Proposed branch: | lp:~akretion-team/openerp-product-attributes/openerp-product-attributes-product-image |
Merge into: | lp:~product-core-editors/openerp-product-attributes/7.0 |
Diff against target: |
314 lines (+289/-0) 5 files modified
product_image/__init__.py (+24/-0) product_image/__openerp__.py (+49/-0) product_image/product.py (+76/-0) product_image/product_image.py (+64/-0) product_image/product_image_view.xml (+76/-0) |
To merge this branch: | bzr merge lp:~akretion-team/openerp-product-attributes/openerp-product-attributes-product-image |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Pedro Manuel Baeza | Needs Fixing | ||
Review via email: mp+222397@code.launchpad.net |
Description of the change
Hi, I refactor and simplify the module product image based on the new field ImageField and ImageResizeField.
This merge depend of this one https:/
Regarding the old Product Images module what do we do? Remove it? set uninstable?
Unmerged revisions
- 248. By Sébastien BEAU - http://www.akretion.com
-
[IMP] add description
- 247. By Sébastien BEAU - http://www.akretion.com
-
[REF] rename view id
- 246. By Sébastien BEAU - http://www.akretion.com
-
[FIX] fix new api attribute for image
- 245. By Sébastien BEAU - http://www.akretion.com
-
[REF] update field to the new API
- 244. By Sébastien BEAU - http://www.akretion.com
-
[REF] refactor code product image, improve view, use imageField and imageResizeField
- 243. By Sébastien BEAU - http://www.akretion.com
-
[ADD] create the module product_image. This module is a kind of fork of product_images. As it will be hard to migrate it maybe the best solution will to have the both module installed and then to run a script and uninstall product_images. This is why I fork in order to have the both modules installable. First step is to copy paste from product_images what I need for my new module
Hi, Sébastien,
Thanks for the refactoring. I haven't seen yet your new module, but for the question you made, I would change the approach a little, having the same module name with a greater version, and making a migration script that converts old data to new approach with the new fields, because having two modules product_image and product_images is not optimal, and setting to uninstallable lets users base that has already installed this module hanged.
Regards.