Code review comment for lp:~akretion-team/openerp-product-attributes/openerp-product-attributes-product-image

Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Sébastien,

Thanks for the refactoring. I haven't seen yet your new module, but for the question you made, I would change the approach a little, having the same module name with a greater version, and making a migration script that converts old data to new approach with the new fields, because having two modules product_image and product_images is not optimal, and setting to uninstallable lets users base that has already installed this module hanged.

Regards.

review: Needs Fixing

« Back to merge proposal