Code review comment for lp:~akretion-team/openerp-product-attributes/mixin-extraction

Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :

Hello will do that as soon as possible (hopefully today), sorry for the
delay.

On Tue, Mar 19, 2013 at 4:49 AM, Guewen Baconnier @ Camptocamp <
<email address hidden>> wrote:

> Review: Needs Fixing
>
> I'm fine to merge this proposal without changing the nitpickings.
> But `openerp.osv.orm.setup_modifiers` has to be called on the fields.
> Raphaël, can you just change this please? The merge proposal can then be
> merged.
>
> By the way, that's really nice to have extracted this behavior from the
> product models to a generic module.
> --
>
> https://code.launchpad.net/~akretion-team/openerp-product-attributes/mixin-extraction/+merge/151333
> Your team OpenERP Community is subscribed to branch
> lp:openerp-product-attributes.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openerp-community
> More help : https://help.launchpad.net/ListHelp
>

« Back to merge proposal