Code review comment for lp:~akretion-team/openerp-connector-magento/7-htaccess-auth-support-dbl
Revision history for this message
| Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote | # |
review:
Needs Fixing
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Interesting. But why put the user and password in the location if 1. they need to be parsed/extracted afterwards, 2. they are used only for the urlopen() of the images but not for the API.
I would prefer to have 2 additional fields for that.
That would also avoid to have the password leaked in the log file each time we log the URL.
Thanks