Hi,
Thanks for the contribs !
My opinion on that one is that I prefer letting this method "def statement_import" as it is. His purpose is to import one single statement.
Why not simply adding a new method called "def multi_statement_import" that call the first one for each instance ?
This way, you reduce the risk of breaking others work by returning a dict instead of a int/long.
For this reason, I mark it as need fixing.
Regards,
Joël
« Back to merge proposal
Hi,
Thanks for the contribs !
My opinion on that one is that I prefer letting this method "def statement_import" as it is. His purpose is to import one single statement.
Why not simply adding a new method called "def multi_statement _import" that call the first one for each instance ?
This way, you reduce the risk of breaking others work by returning a dict instead of a int/long.
For this reason, I mark it as need fixing.
Regards,
Joël