Merge lp:~akretion-team/banking-addons/bank-statement-reconcile-61-repository into lp:banking-addons/bank-statement-reconcile-61

[Benoit Guillot - http://www.akretion.com]

This merge proposal adds a module to import bank statement automaticaly from a repository (ftp, sftp, ...)
This module uses a generic module : file_repository from the project : https://code.launchpad.net/file-exchange

Thanks

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

It's ok for me. Already in production :)

[lp:~akretion-team/banking-addons/bank-statement-reconcile-61-repository]

83. By Sébastien BEAU - http://www.akretion.com on 2013-07-10

[FIX] fix the file name use datas_fname instead of name

84. By Sébastien BEAU - http://www.akretion.com on 2013-07-11

[IMP] when importing a bank statement from a repository the file in not anymore attached but the file document is linked to the bank statement

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Hi Benoit !

First, thank you very much for this MP and contribution. Your code seems ok for me. It's a very useful one. But I have a problem with the dependencies here.

Firstly, I don't want to merge a module in community addons if it depends on module that are not in the communtiy addons. Here, your rely on module in a branch called http://bazaar.launchpad.net/~akretion-team/file-exchange taht belong to Akretion team... Moreover: file_repository depends on 'file_autotask_rel' that depends on file_document and abstract_automatic_task and file_document that depends also on abstract_automatic_task.

Here I don't even find the abstract_automatic_task module in that branch.

So if I'm in favor of including this module in that project, I cannot accept that much dependencies on it that are not part of the communtiy addons. Community addons must rely only on other community one to ensure a proper quality.

For those reasons, I must refuse your proposal unless you remove the dependencies or include all of them in community addons.

I hope you understand our point of view here.

Regards,

Joël

review: Disapprove (c)

[Benoit Guillot - http://www.akretion.com (benoit-guillot-z)]

Hello Joël,

Thanks for your review.

About the branch file-exchange, it is because I didn't know exactly where to propose those modules. Indeed they are abstract so they can't take part of the different branches I found here : https://doc.openerp.com/v7.0/contribute/02_working_in_teams/

The modules are used for the exchange of files so they can be used in accounting with the bank statements, in logistic with a logistician, for the edi files of a carrier ...

I am totaly agreed for including the modules of the branch file-exchange in the community addons, this is their purpose !

We should discuss to decide if it's better to create a new branch or to include them in an existing one.

About the module abstract_automatic_task, it's in the branch : https://code.launchpad.net/~extra-addons-commiter/openobject-extension/oerp6.1-stable.
This branch is maintained by the extra-addons-commiter, so is it the same problem ?

Thanks again for your reply and explanations, hope we will find a way to include this module, it's very cool for the import of the bank statements !

Regards,

Benoît

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

Hi Joel, It's ok for us and we are fully agree to push all of our wrk in Community branch so the question is : "where we should include this module?". I think we need a specific projet right?
Regarding the abstract_automatic_task it's in openobject-extension, maybe we can also push this branch in the community one?

What do you think?

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

The right place to discuss of that should be in the community list I think, it will maybe ends with a new community project, or maybe we'll find an already existing project for them.

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Any updates here ?

[Holger Brunn (Therp) (hbrunn)]

Nice module! I share Joel's opinion about the dependencies though.

If they were mine, I'd propose them to server-env-tools.

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Hi,

It seems that we're in the process of porting the file_exchange stuff in coordination with Akretion team. We also adding a module to import the statement lines using the generic connector (will allow importing thousands of records).

I see 2 possibilities here:

 * Or Akretion sumbmit a MP for file_exchange
 * Or we reject this MP

Thanks,

review: Needs Information

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

Hi,
First we will push in the community project 'file-exchange' on 7 version and make some improvement/change in order to respect the OCA standard.
Then if we have the time we will also clean up the version 6.1 and for a review to the community.

So for now we can reject the merge and focus on 7 version.

Unmerged revisions

84. By Sébastien BEAU - http://www.akretion.com on 2013-07-11

[IMP] when importing a bank statement from a repository the file in not anymore attached but the file document is linked to the bank statement

83. By Sébastien BEAU - http://www.akretion.com on 2013-07-10

[FIX] fix the file name use datas_fname instead of name

82. By Benoit Guillot - http://www.akretion.com on 2013-07-01

[ADD] add module to import account bank statement from a repository

=== added directory 'account_statement_repository'
=== added file 'account_statement_repository/__init__.py'
--- account_statement_repository/__init__.py	1970-01-01 00:00:00 +0000
+++ account_statement_repository/__init__.py	2013-07-11 00:32:27 +0000
@@ -0,0 +1,26 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#
+#   account_statement_repository for OpenERP
+#   Copyright (C) 2013 Akretion (http://www.akretion.com). All Rights Reserved
+#   @author Benoît GUILLOT <[e-mail]>
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as
+#   published by the Free Software Foundation, either version 3 of the
+#   License, or (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU Affero General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+###############################################################################
+
+import file_document
+import abstract_task
+import file_repository
+import statement
 
=== added file 'account_statement_repository/__openerp__.py'
--- account_statement_repository/__openerp__.py	1970-01-01 00:00:00 +0000
+++ account_statement_repository/__openerp__.py	2013-07-11 00:32:27 +0000
@@ -0,0 +1,47 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#
+#   account_statement_repository for OpenERP
+#   Copyright (C) 2013 Akretion (http://www.akretion.com). All Rights Reserved
+#   @author Benoît GUILLOT <[e-mail]>
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as
+#   published by the Free Software Foundation, either version 3 of the
+#   License, or (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU Affero General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+###############################################################################
+
+
+{
+    'name': 'account_statement_repository',
+    'version': '0.1',
+    'category': 'Generic Modules/Others',
+    'license': 'AGPL-3',
+    'description': """
+    This module use tasks created with the module file_repository to import automaticaly account statements.
+    The module file_repository is in the project : https://code.launchpad.net/file-exchange
+    """,
+    'author': 'Akretion',
+    'website': 'http://www.akretion.com/',
+    'depends': ['file_repository',
+                'account_statement_base_import',
+                ],
+    'init_xml': [],
+    'update_xml': [
+           'file_document_view.xml',
+           'file_repository_view.xml',
+           'statement_view.xml',
+    ],
+    'demo_xml': [],
+    'installable': True,
+    'active': False,
+}
 
=== added file 'account_statement_repository/abstract_task.py'
--- account_statement_repository/abstract_task.py	1970-01-01 00:00:00 +0000
+++ account_statement_repository/abstract_task.py	2013-07-11 00:32:27 +0000
@@ -0,0 +1,33 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#
+#   account_statement_repository for OpenERP
+#   Copyright (C) 2013 Akretion (http://www.akretion.com). All Rights Reserved
+#   @author Benoît GUILLOT <[e-mail]>
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as
+#   published by the Free Software Foundation, either version 3 of the
+#   License, or (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU Affero General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+###############################################################################
+
+from openerp.osv import orm
+
+
+class automatic_task(orm.Model):
+    _inherit = "automatic.task"
+
+    def get_task_type(self, cr, uid, context=None):
+        res = super(automatic_task, self).get_task_type(cr, uid, context=context)
+        res.append(('bank_statement', 'Bank Statement Import'))
+        return res
+
 
=== added file 'account_statement_repository/file_document.py'
--- account_statement_repository/file_document.py	1970-01-01 00:00:00 +0000
+++ account_statement_repository/file_document.py	2013-07-11 00:32:27 +0000
@@ -0,0 +1,58 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#
+#   account_statement_repository for OpenERP
+#   Copyright (C) 2013 Akretion (http://www.akretion.com). All Rights Reserved
+#   @author Benoît GUILLOT <[e-mail]>
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as
+#   published by the Free Software Foundation, either version 3 of the
+#   License, or (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU Affero General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+###############################################################################
+
+from openerp.osv import fields, orm
+import os
+
+
+class file_document(orm.Model):
+    _inherit = "file.document"
+
+    def get_file_document_type(self, cr, uid, context=None):
+        res = super(file_document, self).get_file_document_type(cr, uid, context=context)
+        res.append(('bank_statement', 'Bank Statement Import'))
+        return res
+
+    _columns = {
+        'statement_profile_id': fields.many2one('account.statement.profile',
+                                                string='Account Statement Profile')
+    }
+
+    def _run(self, cr, uid, filedocument, context=None):
+        if context is None:
+            context = {}
+        super(file_document, self)._run(cr, uid, filedocument, context=context)
+        acc_profile_obj = self.pool['account.statement.profile']
+        attach_obj = self.pool['ir.attachment']
+        if filedocument.file_type == 'bank_statement':
+            (shortname, ftype) = os.path.splitext(filedocument.datas_fname)
+            ctx = context.copy()
+            ctx['default_file_id'] = filedocument.id
+            acc_profile_obj.statement_import(
+                                            cr,
+                                            uid,
+                                            False,
+                                            filedocument.statement_profile_id.id,
+                                            filedocument.datas,
+                                            ftype.replace('.', ''),
+                                            context=ctx,
+                                        )
 
=== added file 'account_statement_repository/file_document_view.xml'
--- account_statement_repository/file_document_view.xml	1970-01-01 00:00:00 +0000
+++ account_statement_repository/file_document_view.xml	2013-07-11 00:32:27 +0000
@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+    <data>
+
+        <!-- INHERITED VIEW FOR THE OBJECT : file_document -->
+
+        <record id="file_document_view_form" model="ir.ui.view">
+            <field name="name">bank_statement_repository.file_document.view_form</field>
+            <field name="model">file.document</field>
+            <field name="inherit_id" ref="file_repository.file_document_view_form" />
+            <field name="type">form</field>
+            <field name="arch" type="xml">
+                <data>
+                    <field name="file_type" position="after">
+                        <field name="statement_profile_id"
+                               attrs="{'invisible':[('file_type', '!=', 'bank_statement')],
+                                       'required':[('file_type', '=', 'bank_statement')]}"/>
+                    </field>
+                </data>
+            </field>
+        </record>
+
+    </data>
+</openerp>
 
=== added file 'account_statement_repository/file_repository.py'
--- account_statement_repository/file_repository.py	1970-01-01 00:00:00 +0000
+++ account_statement_repository/file_repository.py	2013-07-11 00:32:27 +0000
@@ -0,0 +1,43 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#
+#   account_statement_repository for OpenERP
+#   Copyright (C) 2013 Akretion (http://www.akretion.com). All Rights Reserved
+#   @author Benoît GUILLOT <[e-mail]>
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as
+#   published by the Free Software Foundation, either version 3 of the
+#   License, or (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU Affero General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+###############################################################################
+
+from openerp.osv import fields, orm
+
+
+class repository_task(orm.Model):
+    _inherit = "repository.task"
+
+    _columns = {
+        'statement_profile_id': fields.many2one('account.statement.profile',
+                                                string='Account Statement Profile')
+    }
+
+    def prepare_document_vals(self, cr, uid, task, file_name, datas, context=None):
+        vals = super(repository_task, self).prepare_document_vals(cr, uid,
+                                                                  task,
+                                                                  file_name,
+                                                                  datas,
+                                                                  context=context)
+        if task.type == 'bank_statement':
+            vals.update({'file_type': task.type,
+                         'statement_profile_id': task.statement_profile_id.id})
+        return vals
 
=== added file 'account_statement_repository/file_repository_view.xml'
--- account_statement_repository/file_repository_view.xml	1970-01-01 00:00:00 +0000
+++ account_statement_repository/file_repository_view.xml	2013-07-11 00:32:27 +0000
@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+    <data>
+
+        <!-- INHERITED VIEW FOR THE OBJECT : repository_task -->
+
+        <record id="view_repository_task_form" model="ir.ui.view">
+            <field name="name">bank_statement_repository.repository_task.view_form</field>
+            <field name="model">repository.task</field>
+            <field name="inherit_id" ref="file_repository.view_repository_task_form" />
+            <field name="type">form</field>
+            <field name="arch" type="xml">
+                <data>
+                    <field name="active" position="after">
+                        <field name="statement_profile_id"
+                               attrs="{'invisible':[('type', '!=', 'bank_statement')],
+                                       'required':[('type', '=', 'bank_statement')]}"/>
+                    </field>
+                </data>
+            </field>
+        </record>
+
+    </data>
+</openerp>
 
=== added file 'account_statement_repository/statement.py'
--- account_statement_repository/statement.py	1970-01-01 00:00:00 +0000
+++ account_statement_repository/statement.py	2013-07-11 00:32:27 +0000
@@ -0,0 +1,40 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#
+#   account_statement_repository for OpenERP
+#   Copyright (C) 2013 Akretion (http://www.akretion.com). All Rights Reserved
+#   @author Benoît GUILLOT <[e-mail]>
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as
+#   published by the Free Software Foundation, either version 3 of the
+#   License, or (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU Affero General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+###############################################################################
+
+from openerp.osv import fields, orm
+
+class account_bank_statement(orm.Model):
+    _inherit = "account.bank.statement"
+
+    _columns = {
+        'file_id': fields.many2one('file.document', string='File Document')
+    }
+
+class AccountStatementProfil(orm.Model):
+    _inherit = "account.statement.profile"
+
+    def _attach_file_stream(self, cr, uid, statement_id, file_stream, ftype, context=None):
+        if context.get('default_file_id'):
+            return True
+        else:
+            return super(account_bank_statement, self)._attach_file_stream(cr,
+                    uid, statement_id, file_stream, ftype, context=context)
 
=== added file 'account_statement_repository/statement_view.xml'
--- account_statement_repository/statement_view.xml	1970-01-01 00:00:00 +0000
+++ account_statement_repository/statement_view.xml	2013-07-11 00:32:27 +0000
@@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+    <data>
+
+        <!-- INHERITED VIEW FOR THE OBJECT : file_document -->
+
+        <record id="view_bank_statement_form" model="ir.ui.view">
+            <field name="name">bank_statement_repository.account.bank.statement</field>
+            <field name="model">account.bank.statement</field>
+            <field name="inherit_id" ref="account_statement_ext.view_treasury_statement_form"/>
+            <field name="type">form</field>
+            <field name="arch" type="xml">
+                <field name="profile_id" position="after">
+                    <field name="file_id"
+                           attrs="{'invisible':[('file_id', '=', False)]}"/>
+                </field>
+            </field>
+        </record>
+
+    </data>
+</openerp>