Code review comment for lp:~akretion-team/banking-addons/bank-statement-reconcile-61-ref-base-completion

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

> I would expect .value to work in 283, but not in 286. But wouldn't you be
> better off to use the string representation for both? Then you don't need to
> know anything about the exception's internals and that's just the idea for the
> rule that exceptions should have a meaningful string representation.
> (ErrorTooManyPartner does that)

Holger is right, as of python 2.6, BaseException.message has been deprecated and should be replaced by the string representation of the exception instead.

review: Needs Fixing

« Back to merge proposal