Code review comment for lp:~akretion-team/banking-addons/account_statement_base_import_conversion_dict

Revision history for this message
Sébastien BEAU - http://www.akretion.com (sebastien.beau) wrote :

I approve this merge.
Note the key "extra_fields" have been introduced here : http://bazaar.launchpad.net/~banking-addons-team/banking-addons/bank-statement-reconcile-70/revision/94#account_statement_base_import/parser/file_parser.py
I thinks it's better to come back with the convertion_dict because the FileParser is an abstract Parser for file, and can be reuse in many case (Paypal, Atos, Paybox...). So the convert dict depend of the implementation of the Parser and can not be generic

review: Approve (code review, no test)

« Back to merge proposal