Banking Addons

Code review comment for lp:~akretion-team/banking-addons/70-sepa-trf-dd-updates

  1. 70-sepa-trf-dd-updates
  2. Merge into banking-addons-70
Revision history for this message
Alexis de Lattre (alexis-via) wrote :

@Stefan

Thanks for your very clear explaination about BIC and for the URL you provided. It is very clear for me now.

I made some test on the website of a French bank and read this interesting document which precisely deal with this topic (the doc is in French, sorry) :
http://universwiftnet.files.wordpress.com/2013/07/addendum-guides-utilisation-standard-iso20022-remises-ordres-sepa-v1-0.pdf

This document underline a small detail that I didn't catch when reading the guidelines of the EPC : in a credit transfer, for the creditor, you should not put the CreditorAgent block at all (but, in a direct debit, for the debtor, you should use the current implementation Financial Institution Identification > Other > Identification = NOTPROVIDED). I checked again in the guidelines of the EPC and it confirm this. So I have just modified my code to reflect this.

About the exception, you are right, my code is not as good as it should. I am not an expert in this, but i'll try to do better in a later commit.

« Back to merge proposal