Code review comment for lp:~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update

Just a quick note about what I discovered while trying to backport the module to OpenERP 6.1 : the ORM function resolve_2many_commands exists in OpenERP 6.1 under a different name : resolve_o2m_commands_to_record_dicts

But, unfortunately, when trying to use it, I often get :

File "/home/alexis/new_boite/dev/server-61/openerp/osv/orm.py", line 4975, in resolve_o2m_commands_to_record_dicts
    "Only CREATE, UPDATE and LINK_TO commands are supported in resolver"

When you look at the code of this function in openerp 6.1 in openerp/osv/orm.py, you see that it only handles commands 0, 1 and 4 ; whereas the same code in OpenERP 7.0 handles 0, 1, 2, 3, 4, 5 and 6.

During my tests, I got a command "6", so I hit the assert and it crashes.

So, if you don't have a better idea, a backport to OpenERP 6.1 of this module would probably use the "update" button approach.