Code review comment for lp:~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update
Revision history for this message
| Ronald Portier (Therp) (rportier1962) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Thanks Alexis for updating the module.
As for the question button or on_change: I have always been amazed (and annoyed) at the need to press the update button in order to have your taxes computed.
Having the user needing to press a button carries the possibility that he/she will forget this. With not computing taxes this error is very obvious. But with the change in fiscal position, I think the odds that users once in a while forget this are very high.
If it ever happens that a user changes a fiscal position by accident (and saves the form before realising his/her mistake), just changing back the fiscal position will easily revert taxes and accounts. And yes with a few hundred lines this might take a moment. But what are the odds that AND an invoice will have > 200 lines AND the user will change the fiscal position by mistake?