Code review comment for lp:~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update
Revision history for this message
| Mathieu Vatel - Julius Network Solutions (mathieu-julius) wrote | # |
review:
Approve
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Hi everybody,
For me, pressing a button is the better solution. Of course this can be done by only changing the fiscal position using an on_change.
The thing is, if you've got more than 100-200 lines to invoice, and you just change "accidentally" the fiscal position, this will run the change on all lines, and can take some time. This is a "security" for me.
I've first developed this module with a button to avoid errors done by new users and with many many lines inside the invoice (~500-1000 lines).
We can use the on_change method, I'm OK to use it. But I think this should avoid many errors using a button.
Otherwise, I totally approve this module migration ! Thank you Alexis !