Code review comment for lp:~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update
Revision history for this message
| Alexis de Lattre (alexis-via) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
@Graeme
I agree with your remarks about the fact that a fiscal position is not dependant on a product. But, as you say, implementing it without relying on the product is not really possible, because if you already had a fiscal position and you change to another fiscal position, that you can't use the mapping of the new fiscal position to update the taxes and accounts.
One solution would be to raise an error message, which would block the executing and prevent all lines from being updated. The second solution would be to display a warning, but AFAIK, it is not possible on a function executed by a button unfortunately.
@Ronald
About the on_change vs the update button : I don't have a strong opinion on this. The original author of the module (Mathieu Vatel) implemented it via an update button and I kept this approach. If there is a consensus to use an on_change, then I'm OK to use an on_change.