Merge lp:~akopytov/percona-xtrabackup/bug943750-2.2 into lp:percona-xtrabackup/2.2

Proposed by Alexey Kopytov
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 4874
Proposed branch: lp:~akopytov/percona-xtrabackup/bug943750-2.2
Merge into: lp:percona-xtrabackup/2.2
Diff against target: 43 lines (+27/-1)
2 files modified
xtrabackup/innobackupex (+1/-1)
xtrabackup/test/t/bug943750.sh (+26/-0)
To merge this branch: bzr merge lp:~akopytov/percona-xtrabackup/bug943750-2.2
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
Review via email: mp+187000@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) wrote :
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Self-approving, trivial change.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'xtrabackup/innobackupex'
--- xtrabackup/innobackupex 2013-09-16 17:23:00 +0000
+++ xtrabackup/innobackupex 2013-09-23 10:52:58 +0000
@@ -251,7 +251,7 @@
251my $src_name;251my $src_name;
252my $dst_name;252my $dst_name;
253my $win = ($^O eq 'MSWin32' ? 1 : 0);253my $win = ($^O eq 'MSWin32' ? 1 : 0);
254my $CP_CMD = ($win eq 1 ? "copy /Y" : "cp -p");254my $CP_CMD = ($win eq 1 ? "copy /Y" : "cp");
255my $xtrabackup_binary_file = 'xtrabackup_binary';255my $xtrabackup_binary_file = 'xtrabackup_binary';
256my $xtrabackup_pid_file = 'xtrabackup_pid';256my $xtrabackup_pid_file = 'xtrabackup_pid';
257my %rsync_files_hash;257my %rsync_files_hash;
258258
=== added file 'xtrabackup/test/t/bug943750.sh'
--- xtrabackup/test/t/bug943750.sh 1970-01-01 00:00:00 +0000
+++ xtrabackup/test/t/bug943750.sh 2013-09-23 10:52:58 +0000
@@ -0,0 +1,26 @@
1################################################################################
2# Bug #943750: innobackupex doesn't backup to nfs mount point
3################################################################################
4
5# Create a fake cp that will fail if '-p' is passed by innobackupex
6
7cat >$topdir/cp <<"EOF"
8#!/bin/bash
9
10args=""
11while (( "$#" ))
12do
13 if [ "$1" = "-p" ]
14 then
15 echo "'-p' passed as an argument to 'cp'!"
16 exit 1
17 fi
18 args="$args $1"
19 shift
20done
21/bin/cp $args
22EOF
23
24chmod +x $topdir/cp
25
26PATH=$topdir:$PATH . inc/xb_local.sh

Subscribers

People subscribed via source and target branches

to all changes: