Code review comment for lp:~akopytov/percona-xtrabackup/bug1183793-2.1

Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

Are lines

88 + rlimit.rlim_cur = 0; /* Safety if next call fails */
89 +
90 + (void) getrlimit(RLIMIT_NOFILE, &rlimit);
91 +
92 + if (rlimit.rlim_cur) {

work different from

nn + if (!getrlimit(RLIMIT_NOFILE, &rlimit)) {

man page suggest to use return value for error handling and says nothing about using rlim_cur for this purpose.

review: Needs Information (g2)

« Back to merge proposal