Code review comment for lp:~akopytov/percona-xtrabackup/bug1170806-2.0
Revision history for this message
| Alexey Kopytov (akopytov) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
4d1350f
(Get the code!)
Hi George,
On Wed, 24 Apr 2013 16:33:24 -0000, George Ormond Lorch III wrote:
> Review: Approve g2
>
> Looks good except for one more general question. There seems to be a lot of exit(EXIT_FAILURE) which bypasses all resource cleanup operations. Basic OS resources (memory, open files, etc) are not a big deal as they will be cleaned up on exit, but we do use temp files and some external libraries/tools that may also have some temporary resources left behind if not de-initialized/shut down cleanly. Should we consider a new blueprint to implement a better cleanup on error?
>
So files is the only concern. All temporary files should be properly
created so that they are removed automatically on process termination
(bug #1172016 was a result of a typo). And I'm not sure we should put
any effort into cleaning up non-temporary files (basically, data files).
We don't remove backup data on a failed backup currently. Even if we do
that on exit(), they will still be left behind on a crash.