Code review comment for lp:~akopytov/percona-xtrabackup/bug1130627-2.0

Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

Alexey,

* get_table_name_with_part_suffic - is it a typo?
* innobackupex change affects only --include option (which is regex) and
  doesn't affects --databases option, i.e. with --databases option individual
  partitions still cannot be backed up
* while xtrabackup change affects both --tables and --tables-file (one with regexp, another one without)
  which looks to me as kind of inconsistency
* check_if_table_matches_regexps doesn't look like a good name since it not
  only matches against regexps, but also against table names from --tables-file
* would also be nice to have testcases which take a backup only of some partitions
  with different combinations of options

review: Needs Fixing (g2)

« Back to merge proposal