Code review comment for lp:~akopytov/percona-xtrabackup/bug1095249-2.0

George Ormond Lorch III (gl-az) wrote :

I see now why you re-wrote the ds chaining in 2.1. I don't like that the compression sink needs to manage it's connection to the next sink (the buffer in this case) rather than having it done at the higher level in xtrabackup.c like it is now done in 2.1.

Anyway, looks like a reasonable fix to the issue.

review: Approve (g2)

« Back to merge proposal