Merge lp:~akopytov/percona-xtrabackup/bug1095249-2.0 into lp:percona-xtrabackup/2.0
Proposed by
Alexey Kopytov
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Laurynas Biveinis | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 494 | ||||
Proposed branch: | lp:~akopytov/percona-xtrabackup/bug1095249-2.0 | ||||
Merge into: | lp:percona-xtrabackup/2.0 | ||||
Diff against target: |
378 lines (+289/-8) 6 files modified
src/Makefile (+2/-1) src/buffer.c (+197/-0) src/buffer.h (+31/-0) src/compress.c (+22/-4) src/datasink.h (+5/-3) test/t/ib_compress_basic.sh (+32/-0) |
||||
To merge this branch: | bzr merge lp:~akopytov/percona-xtrabackup/bug1095249-2.0 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Laurynas Biveinis (community) | Approve | ||
George Ormond Lorch III (community) | g2 | Approve | |
Review via email: mp+141769@code.launchpad.net |
To post a comment you must log in.
I see now why you re-wrote the ds chaining in 2.1. I don't like that the compression sink needs to manage it's connection to the next sink (the buffer in this case) rather than having it done at the higher level in xtrabackup.c like it is now done in 2.1.
Anyway, looks like a reasonable fix to the issue.