Merge lp:~akopytov/percona-xtrabackup/ST-26761-bug1065561-2.0 into lp:percona-xtrabackup/2.0

Proposed by Alexey Kopytov
Status: Merged
Approved by: Stewart Smith
Approved revision: no longer in the source branch.
Merged at revision: 477
Proposed branch: lp:~akopytov/percona-xtrabackup/ST-26761-bug1065561-2.0
Merge into: lp:percona-xtrabackup/2.0
Diff against target: 51 lines (+19/-0)
1 file modified
src/xtrabackup.c (+19/-0)
To merge this branch: bzr merge lp:~akopytov/percona-xtrabackup/ST-26761-bug1065561-2.0
Reviewer Review Type Date Requested Status
Stewart Smith (community) Approve
Sergei Glushchenko (community) g2 Approve
Review via email: mp+130505@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

Approve G2

review: Approve (g2)
Revision history for this message
Stewart Smith (stewart) :
review: Approve
Revision history for this message
Stewart Smith (stewart) wrote :

(this seems to cleanly merge into 2.1 tree too, so i'm merging it)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/xtrabackup.c'
--- src/xtrabackup.c 2012-09-13 10:28:54 +0000
+++ src/xtrabackup.c 2012-10-19 16:06:20 +0000
@@ -1081,6 +1081,9 @@
1081 OPT_INNODB_READ_IO_THREADS,1081 OPT_INNODB_READ_IO_THREADS,
1082 OPT_INNODB_WRITE_IO_THREADS,1082 OPT_INNODB_WRITE_IO_THREADS,
1083#endif1083#endif
1084#if MYSQL_VERSION_ID >= 50500
1085 OPT_INNODB_USE_NATIVE_AIO,
1086#endif
1084#ifdef XTRADB_BASED1087#ifdef XTRADB_BASED
1085 OPT_INNODB_PAGE_SIZE,1088 OPT_INNODB_PAGE_SIZE,
1086 OPT_INNODB_LOG_BLOCK_SIZE,1089 OPT_INNODB_LOG_BLOCK_SIZE,
@@ -1350,6 +1353,13 @@
1350 "How many files at the maximum InnoDB keeps open at the same time.",1353 "How many files at the maximum InnoDB keeps open at the same time.",
1351 (G_PTR*) &innobase_open_files, (G_PTR*) &innobase_open_files, 0,1354 (G_PTR*) &innobase_open_files, (G_PTR*) &innobase_open_files, 0,
1352 GET_LONG, REQUIRED_ARG, 300L, 10L, LONG_MAX, 0, 1L, 0},1355 GET_LONG, REQUIRED_ARG, 300L, 10L, LONG_MAX, 0, 1L, 0},
1356#if MYSQL_VERSION_ID >= 50500
1357 {"innodb_use_native_aio", OPT_INNODB_USE_NATIVE_AIO,
1358 "Use native AIO if supported on this platform.",
1359 (G_PTR*) &srv_use_native_aio,
1360 (G_PTR*) &srv_use_native_aio, 0, GET_BOOL, NO_ARG,
1361 FALSE, 0, 0, 0, 0, 0},
1362#endif
1353#ifdef XTRADB_BASED1363#ifdef XTRADB_BASED
1354 {"innodb_page_size", OPT_INNODB_PAGE_SIZE,1364 {"innodb_page_size", OPT_INNODB_PAGE_SIZE,
1355 "The universal page size of the database.",1365 "The universal page size of the database.",
@@ -4018,6 +4028,10 @@
4018#endif4028#endif
4019 fil_system = NULL;4029 fil_system = NULL;
40204030
4031 /* Reset srv_file_io_threads to its default value to avoid confusing
4032 warning on --prepare in innobase_start_or_create_for_mysql()*/
4033 srv_n_file_io_threads = 4;
4034
4021 srv_shutdown_state = SRV_SHUTDOWN_NONE;4035 srv_shutdown_state = SRV_SHUTDOWN_NONE;
4022}4036}
40234037
@@ -6432,7 +6446,12 @@
64326446
6433 /* increase IO threads */6447 /* increase IO threads */
6434 if(srv_n_file_io_threads < 10) {6448 if(srv_n_file_io_threads < 10) {
6449#ifndef INNODB_VERSION_SHORT
6435 srv_n_file_io_threads = 10;6450 srv_n_file_io_threads = 10;
6451#else
6452 srv_n_read_io_threads = 4;
6453 srv_n_write_io_threads = 4;
6454#endif
6436 }6455 }
64376456
6438 msg("xtrabackup: Starting InnoDB instance for recovery.\n"6457 msg("xtrabackup: Starting InnoDB instance for recovery.\n"

Subscribers

People subscribed via source and target branches