Merge lp:~akopytov/percona-xtrabackup/ST-26761-bug1065561-2.0 into lp:percona-xtrabackup/2.0

Proposed by Alexey Kopytov
Status: Merged
Approved by: Stewart Smith
Approved revision: no longer in the source branch.
Merged at revision: 477
Proposed branch: lp:~akopytov/percona-xtrabackup/ST-26761-bug1065561-2.0
Merge into: lp:percona-xtrabackup/2.0
Diff against target: 51 lines (+19/-0)
1 file modified
src/xtrabackup.c (+19/-0)
To merge this branch: bzr merge lp:~akopytov/percona-xtrabackup/ST-26761-bug1065561-2.0
Reviewer Review Type Date Requested Status
Stewart Smith (community) Approve
Sergei Glushchenko (community) g2 Approve
Review via email: mp+130505@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

Approve G2

review: Approve (g2)
Revision history for this message
Stewart Smith (stewart) :
review: Approve
Revision history for this message
Stewart Smith (stewart) wrote :

(this seems to cleanly merge into 2.1 tree too, so i'm merging it)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/xtrabackup.c'
2--- src/xtrabackup.c 2012-09-13 10:28:54 +0000
3+++ src/xtrabackup.c 2012-10-19 16:06:20 +0000
4@@ -1081,6 +1081,9 @@
5 OPT_INNODB_READ_IO_THREADS,
6 OPT_INNODB_WRITE_IO_THREADS,
7 #endif
8+#if MYSQL_VERSION_ID >= 50500
9+ OPT_INNODB_USE_NATIVE_AIO,
10+#endif
11 #ifdef XTRADB_BASED
12 OPT_INNODB_PAGE_SIZE,
13 OPT_INNODB_LOG_BLOCK_SIZE,
14@@ -1350,6 +1353,13 @@
15 "How many files at the maximum InnoDB keeps open at the same time.",
16 (G_PTR*) &innobase_open_files, (G_PTR*) &innobase_open_files, 0,
17 GET_LONG, REQUIRED_ARG, 300L, 10L, LONG_MAX, 0, 1L, 0},
18+#if MYSQL_VERSION_ID >= 50500
19+ {"innodb_use_native_aio", OPT_INNODB_USE_NATIVE_AIO,
20+ "Use native AIO if supported on this platform.",
21+ (G_PTR*) &srv_use_native_aio,
22+ (G_PTR*) &srv_use_native_aio, 0, GET_BOOL, NO_ARG,
23+ FALSE, 0, 0, 0, 0, 0},
24+#endif
25 #ifdef XTRADB_BASED
26 {"innodb_page_size", OPT_INNODB_PAGE_SIZE,
27 "The universal page size of the database.",
28@@ -4018,6 +4028,10 @@
29 #endif
30 fil_system = NULL;
31
32+ /* Reset srv_file_io_threads to its default value to avoid confusing
33+ warning on --prepare in innobase_start_or_create_for_mysql()*/
34+ srv_n_file_io_threads = 4;
35+
36 srv_shutdown_state = SRV_SHUTDOWN_NONE;
37 }
38
39@@ -6432,7 +6446,12 @@
40
41 /* increase IO threads */
42 if(srv_n_file_io_threads < 10) {
43+#ifndef INNODB_VERSION_SHORT
44 srv_n_file_io_threads = 10;
45+#else
46+ srv_n_read_io_threads = 4;
47+ srv_n_write_io_threads = 4;
48+#endif
49 }
50
51 msg("xtrabackup: Starting InnoDB instance for recovery.\n"

Subscribers

People subscribed via source and target branches