Code review comment for lp:~akopytov/percona-xtrabackup/BT27412-bug1055989-2.0

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Laurynas,

Thanks for the review. I agree there are currently no problems caused by reusing xtrabackup_suspended file, though the name looks a bit confusing. I could rename it to xtrabackup_lock or something, but I try to do small incremental changes, and not change something unless I absolutely have to.

It does the job for this specific fix. In case we need more fine-grained locking (before merging innobackupex and xtrabackup), we may consider adding more lock files in the future.

Setting to approved, as there are no comments other than those about the lock file name.

review: Approve

« Back to merge proposal