Code review comment for lp:~akopytov/percona-server/i26611-bug1059812-5.5

Alexey -

It's really uncommon to see my_bool instead of ibool outside of handler/ and to lesser extent srv/. I would contain it to these two dirs by changing srv0start.c to

buf_pool_init (... srv_buf_pool_populate ? TRUE : FALSE, ... );

and making the rest of changes use ibool. I think that this horrible one line is still better than mixing bool types in the lower InnoDB subsystems.

The 2.6.23 version check is something I'd rather not see, but brief checking seems to show that this indeed the only way to find out if MAP_PRIVATE | MAP_POPULATE works :(