Code review comment for lp:~akopytov/percona-server/ahi-fixes-5.6

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Hi Laurynas,

On Wed, 04 Sep 2013 15:00:11 -0000, Laurynas Biveinis wrote:
> - Diff line 385--391 drops MONITOR_INC call.
>

Same here. It appears to be some bogus change. This is how rev. diff
looks in my tree:

  #ifdef UNIV_SYNC_DEBUG
- ut_ad(rw_lock_own(btr_search_get_latch(cursor->index->id), RW_LOCK_EX));
+ ut_ad(rw_lock_own(btr_search_get_latch(cursor->index),
+ RW_LOCK_EX));
  #endif /* UNIV_SYNC_DEBUG */

- ha_insert_for_fold(btr_search_get_hash_index(cursor->index->id), fold,
- block, rec);
+ ha_insert_for_fold(btr_search_get_hash_table(cursor->index),
+ fold, block, rec);
   }
  }

I.e. there was simply no MONITOR_INC call. Not sure whom to blame here,
bzr or LP diff viewer.

« Back to merge proposal