Code review comment for ~ajorgens/cloud-init:simpletable

Revision history for this message
Scott Moser (smoser) wrote :

Andrew, wrt useless of launchpad collapsing spaces, you can put it into a
pastebin http://paste.ubuntu.com/ and then point to that.

You dont remove the dep from requirements.txt here, so it probably ends
up still being a dep at least in ubuntu

I'd like to drop prettytable or at very least make it a soft dependency,
falling back to your simpletable if it wasnt there.
There is an issue.. though. We were using pretty table to render human
friendly output to the /dev/console. The expectation was that that was
human friendly, but since we were not rendering any *machine* friendly
representation of said data, its possible or likely that machines
were parsing that.

I'd like to have an actual solution for writing machine-friendly
data somewhere that we could depend on. And then i woudlnt care so much
about the user-friendly text changing.

This cleary isn't your fault, but I'm just kind of adverse to changing
something that kind of worked and possibly breaking someone without
putting somethign else in place that could be relied upon.

« Back to merge proposal