Code review comment for ~ajorgens/cloud-init:pipe-cat

Revision history for this message
Andrew Jorgensen (ajorgens) wrote :

a.) Unfortunately, asking Yum to be quiet means it won't give you any of the debugging information you need when it goes wrong.

b.) Possibly there's a better way to disconnect it from the terminal, but what isatty does is ask the system if stdout is associated with a terminal, so unless you make stdout something other than the one associated with the terminal it will answer that it's a tty. In other words, it has to be piped through something. Piping it through cat seemed the lesser of two evils compared to spinning off a thread (or greenlet or whatever) to consume stdout and spool it to the console.

I'm definitely open to advice on how to do this a better way, if you want to ask around.

« Back to merge proposal